Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] a working /imagen endpoint #4

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

ofey404
Copy link
Collaborator

@ofey404 ofey404 commented May 2, 2023

Part of #3 .

This PR switch /imagen's API backend to stable.

Also, it did a slight refactor to the configuration loading mechanism.

It can still load from .env / environment variable, but in a structured way.

======

Roadmap:

  • First of all, we need a config object/file, in order to tweak things on testing.
  • Set up and run /imagen, to verify it's in a working state.

======

Those are pushed to following PRs:

  • Write the test, based on the working endpoint.
  • Create a mock for external moving parts like hugging face model.
  • Then refactor after we have proper tests.

@ofey404 ofey404 marked this pull request as draft May 2, 2023 13:08
@ofey404
Copy link
Collaborator Author

ofey404 commented May 4, 2023

How to integrate pytest into bazel:

pytest support #240 | rules/python

@ofey404 ofey404 requested a review from Fazziekey May 4, 2023 11:52
@ofey404 ofey404 marked this pull request as ready for review May 4, 2023 11:53
@ofey404 ofey404 changed the title [backend] a tested /imagen endpoint [backend] a working /imagen endpoint May 4, 2023
@Fazziekey Fazziekey merged commit 784a2ca into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants