Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Commit

Permalink
bump timeout on overlapping write requests test
Browse files Browse the repository at this point in the history
At 50ms, we see sporadic failures in CI. So much for "this should
only need a couple milliseconds". Bumped timeout to avoid that.

The challenge here is that we have some tests which *want* to hit
the timeout to confirm that we aren't allowing things we shouldn't.
But we don't want the test to hang forever. But we want to be sure
it is actually stuck and not just being slow...

(cherry picked from commit f1a68f8)
  • Loading branch information
seebs authored and fhaynes committed Dec 12, 2022
1 parent 2709973 commit c99faa1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion querycontext/query_context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ func testOverlappingWriteRequests(t *testing.T, write overlappingWriteReqs) erro
}
t.Fatalf("running reqs: %v", err)
}
case <-time.After(50 * time.Millisecond):
case <-time.After(250 * time.Millisecond):
if !write.shouldError {
// Only log this if we didn't expect an error.
t.Logf("write requests (%d):", len(write.reqs))
Expand Down

0 comments on commit c99faa1

Please sign in to comment.