-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlkylStructureFragmenter Implementation #10
base: production
Are you sure you want to change the base?
Changes from 48 commits
0d207da
8011316
e796701
89988ad
5c283d3
9555f0a
a3f5ab2
543f941
41b8474
9326006
6b71b46
c563270
7139641
c0ae663
1800a8e
ca4a5c8
9c9d1ca
23cc8e5
2e328bb
7c75ece
cbc1c84
e59e0f7
b49017c
e06b346
0c83d87
02d12d6
7eaa4d2
276e9f7
a5645d4
31a2788
2e7d7b6
dfd4063
a6df6bb
93c4d8b
50737bb
7480fe8
66b79db
14ff3c0
c4015db
204d4df
59aaf45
ebe88e8
66e8c10
98f5564
3c6fd9e
736d007
ceb9227
dd3eb2d
27f8952
994119c
fe10aa3
37ac325
fc98e64
e55f047
8457307
975b890
92abad3
faba162
91b0ae1
722a79c
9de9877
0167c04
9c67569
1b2ae70
b0ff2cc
6753a04
ad4945b
80ad1bd
9745ee6
c898b01
be7c4d1
295d5c3
3761c2c
1610a50
6037327
f35de14
a6bc0aa
79a8c52
facaa7d
68928fc
a0a417b
9dcab44
5002211
60848fb
df30210
69fa1c0
26c6481
b06caac
74574d8
7bca034
4d4f007
f38737d
bba7d15
cc96daa
d04d734
1ad9741
cd9aa96
b363891
9064e97
9bf6a3e
0e47cc6
1e5c822
4bcfa15
498151e
480cd41
0c089b5
1bfcc22
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,10 +24,7 @@ | |
import de.unijena.cheminf.mortar.message.Message; | ||
import de.unijena.cheminf.mortar.model.data.FragmentDataModel; | ||
import de.unijena.cheminf.mortar.model.data.MoleculeDataModel; | ||
import de.unijena.cheminf.mortar.model.fragmentation.algorithm.ErtlFunctionalGroupsFinderFragmenter; | ||
import de.unijena.cheminf.mortar.model.fragmentation.algorithm.IMoleculeFragmenter; | ||
import de.unijena.cheminf.mortar.model.fragmentation.algorithm.ScaffoldGeneratorFragmenter; | ||
import de.unijena.cheminf.mortar.model.fragmentation.algorithm.SugarRemovalUtilityFragmenter; | ||
import de.unijena.cheminf.mortar.model.fragmentation.algorithm.*; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert wildcard import as discussed (even though this is a very special case where this might almost make sense...) |
||
import de.unijena.cheminf.mortar.model.settings.SettingsContainer; | ||
import de.unijena.cheminf.mortar.model.util.BasicDefinitions; | ||
import de.unijena.cheminf.mortar.model.util.ChemUtil; | ||
|
@@ -153,6 +150,14 @@ public class FragmentationService { | |
* Scaffold Generator | ||
*/ | ||
private IMoleculeFragmenter ScaffoldGF; | ||
/** | ||
* Alkyl Structure Fragmenter | ||
*/ | ||
private IMoleculeFragmenter AlkylSF; | ||
/** | ||
* Conjugated Pi System Fragmenter | ||
*/ | ||
private IMoleculeFragmenter ConjPiSysF; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The two new fragmenter variables should go to the final class constants like the others. |
||
/** | ||
* List of names of fragmentation algorithms that have already been run | ||
*/ | ||
|
@@ -198,13 +203,17 @@ public class FragmentationService { | |
*/ | ||
public FragmentationService(SettingsContainer aSettingsContainer){ | ||
//Note: Every fragmenter class should only be added once to the array or there will be problems with setting persistence! | ||
this.fragmenters = new IMoleculeFragmenter[3]; | ||
this.fragmenters = new IMoleculeFragmenter[5]; | ||
this.ertlFGF = new ErtlFunctionalGroupsFinderFragmenter(); | ||
this.fragmenters[0] = this.ertlFGF; | ||
this.sugarRUF = new SugarRemovalUtilityFragmenter(); | ||
this.fragmenters[1] = this.sugarRUF; | ||
this.ScaffoldGF = new ScaffoldGeneratorFragmenter(); | ||
this.fragmenters[2] = this.ScaffoldGF; | ||
this.AlkylSF = new AlkylStructureFragmenter(); | ||
this.fragmenters[3] = this.AlkylSF; | ||
this.ConjPiSysF = new ConjugatedPiSystemFragmenter(); | ||
this.fragmenters[4] = this.ConjPiSysF; | ||
// | ||
Objects.requireNonNull(aSettingsContainer, "aSettingsContainer must not be null"); | ||
this.settingsContainer = aSettingsContainer; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check your import settings!