v32 #885
Draft
v32 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't fully remove next-metrics to avoid a large migration, however it does stop n-express from sending any metrics to Graphite by default. This is a breaking change because the lack of metrics could trigger alerts for some apps as data will stop being available for things like `fetch`. The second part of this work will arrive when we roll out next-metrics v13, after this PR is merged Financial-Times/next-metrics#603
This means that apps using n-express will no longer be sending _any_ metrics to Graphite unless they manually install and set up next-metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers together all the work we'll be releasing as v32 of the library. Work has been reviewed in separate PRs.