Fix #8185 - SIGSEGV with WHERE CURRENT OF statement with statement cache turned on #8191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che turned on.
aafemt
reviewed
Jul 23, 2024
| @@ -177,6 +177,9 @@ void DsqlRequest::destroy(thread_db* tdbb, DsqlRequest* dsqlRequest) | |||
| { | |||
| childStatement->addFlags(DsqlStatement::FLAG_ORPHAN); | |||
| childStatement->setParentRequest(nullptr); | |||
| childStatement->setParentDbKey(nullptr); | |||
| childStatement->setParentRecVersion(nullptr); | |||
There was a problem hiding this comment.
Isn't it pointless to clean fields of statement which is going to be removed from cache and thus destructed? FLAG_ORPHAN already prevent any usage of the statement.
|
BTW, where FLAG_ORPHAN is reset so reused statement won't throw "invalid handle" error? |
Statement link to the cursor is established at prepare time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.