Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Inline the endpoint search process #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Mar 15, 2019

Rather than instantiating a new class on every request, this inlines the endpoint search into the dispatcher. Currently it's basically a copy-paste of the classmapper's logic.

There are two high-level goals for this:

  1. Reduce dispatching overhead
  2. Increase format flexibility of the endpoint map, to allow future optimizations to matching

This is tangentially related to #51 and #98.

Before landing:

  • Apply same logic to parser search
  • Add more test coverage

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #104 into master will decrease coverage by 0.47%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
- Coverage      96.5%   96.03%   -0.48%     
- Complexity      125      135      +10     
============================================
  Files            22       22              
  Lines           458      479      +21     
============================================
+ Hits            442      460      +18     
- Misses           16       19       +3
Impacted Files Coverage Δ Complexity Δ
src/Dispatcher.php 95.95% <91.66%> (-2.76%) 34 <10> (+10)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0181a32...70b0ff3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant