Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

547 Prototype to make library types singleton instead of static on 1.0 #552

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Sep 18, 2024

DO NOT MERGE THIS. Performance testing needs to happen to compare to static library types, and if found to be comparable enough, can be cherry picked back into PR #548

@baseTwo baseTwo changed the title Static class 2 511 Prototype to make library types singleton instead of static (1.0) Sep 18, 2024
@baseTwo baseTwo changed the title 511 Prototype to make library types singleton instead of static (1.0) 511 Prototype to make library types singleton instead of static on 1.0 Sep 18, 2024
@DamienMosier
Copy link
Contributor

Ran a performance test on a few measures with a few large decks and performance is comparable between static and singleton.

@EvanMachusak
Copy link
Collaborator

Part of our public API could be something like this:

public static IServiceProvider AddLibraries(this IServiceProvider isp, LibrarySet libraries)
{
  ... compile the library set to assemblies, and then register their types as singletons
}

@baseTwo baseTwo changed the title 511 Prototype to make library types singleton instead of static on 1.0 547 Prototype to make library types singleton instead of static on 1.0 Sep 25, 2024
@baseTwo baseTwo linked an issue Sep 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance hit with numerous class initializations (1.0)
4 participants