575 performance hit with numerous class initializations 2.0 #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional requirements were added to the issue, so changing back to draft |
baseTwo
changed the title
|
Opened again, might be worthwhile to split this issue into two parts with the comments that were added to the original issue. |
ewoutkramer
approved these changes
Oct 14, 2024
ewoutkramer
deleted the
575-performance-hit-with-numerous-class-initializations-20
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for
Updating libraries to only be accessible via the singleton pattern (single static instance property, and private constructor)
Introduced a static interface for this called
ISingleton<TSelf>which contains the propertystatic TSelf Instance { get; }Introduced another interface
ILibrarywhich has three properties:string Name { get; },string Version { get; }andILibrary[] Dependencies { get; }. Having this interface makes it possible to avoid getting to dependencies via reflection. (We could probably add additional members here to make it easier to get to valuesets, etc)