Feature/ch21518/filecoin #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #21518: Space - Filecoin BE. |
jsonsivar
commented
Feb 26, 2021
| @@ -117,6 +117,8 @@ export class IdentityModel extends BaseModel { | |||
|
|
|||
| const result = await this.query(params); | |||
|
|
|||
| console.log('getIdentitiesByDisplayName: ', result); | |||
There was a problem hiding this comment.
Added these logs to troubleshoot another issue. Will clean up once that is fixed.
jsonsivar
commented
Feb 26, 2021
| auth: { | ||
| type: 'AWS_IAM', | ||
| credentials: { | ||
| // is there a way to get these from the lambda role |
There was a problem hiding this comment.
This piece I am not hundred percent on. Will these env vars get populated or maybe there is a way to set this auth to use the default lambda execution role? That's what it should be because the permissions in serverless.yml are set for that.
jsonsivar
commented
Feb 26, 2021
| @@ -40,7 +40,7 @@ export const handler = middy(async function( | |||
| }, | |||
| Subject: { Data: emailBody.subject }, | |||
| }, | |||
| Source: emailBody.from || 'Space <hi@space.storage>', | |||
| Source: emailBody.from || 'Space <hey@space.storage>', | |||
There was a problem hiding this comment.
Unrelated to Filecoin and this fix is already in dev/prd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.