Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

SubGHZ Repeater, Enable Sound Saved to Last Settings. #492

Merged
merged 12 commits into from
Dec 14, 2023

Conversation

LeeroysHub
Copy link
Contributor

What's new

SubGHZ Repeater. Re-transmit keys with no user interaction.


For the reviewer

  • [Y] I've uploaded the firmware with this patch to a device and verified its functionality
  • [Y] I've confirmed the bug to be fixed / feature to be stable

@subeax

This comment was marked as resolved.

@LeeroysHub
Copy link
Contributor Author

Thankyou!

@Willy-JL
Copy link
Contributor

very well done!

i just fixed up a few bits of logic with the timer being allocated even if it already existed, changed it to a type once instead of timer periodic and stopping on first callback. also made it so variable items can be set as locked without passing the text again, fixes duplication. also the binraw index is already done with the enum, no need to keep a separate index :D. and the binraw/repeater logic could have been a bit cleaner in receiver enter, but the idea was absolutely correct.

i think i will do one last change, so that when i nrepeater mode the receiver view doesnt show received signals. its a bit confusing when you have signals, then switch to repeater and the signals are still there... no indication of repeater apart from led/sound, and you wont get new signals in the list.

other than that all looks great, thanks!

@Willy-JL
Copy link
Contributor

changed it instead so that when enabling repeater it will check if history has signals and ask to discard or keep them

@Willy-JL Willy-JL merged commit ffc510b into Flipper-XFW:dev Dec 14, 2023
3 checks passed
@Willy-JL Willy-JL added the enhancement New feature or request label Dec 14, 2023
@LeeroysHub
Copy link
Contributor Author

I have just changed the Repeater code to properly get the Key transmit Time. Te * Bits is the time for s key to transmit, not Te in Milliseconds. Small change, but want to make it all correct!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants