-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1509 fetch() implementation #5372
Conversation
@ioanmo226 this issue is part of bigger refactoring to implement Manifest V3 requirements, which should be required in the future for all extensions. In this PR we switch to using Roman worked on this switch, but there were some issues in loading messages in Firefox, as currently it doesn't support some features of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. small comments
By the way, might better to add another reviewer as this seems breaking changes and I might have missed something? |
Unfortunately Roman doesn't work on FlowCrypt anymore, that's why I was finalising this PR. |
Got it. |
Please check test |
We've missed that Google API urls have different base urls - |
This PR replaces JQuery ajax calls with fetch()
Modifies the mock API to use HTTP/2 -- required to display fetch upload progress.
issue #1509
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):