-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich crash email with detail and hints where crash reason can be inferred #4936
Conversation
@joepavitt added as 2nd reviewer for the visual aspect |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
==========================================
+ Coverage 78.31% 78.37% +0.05%
==========================================
Files 326 328 +2
Lines 15387 15438 +51
Branches 3536 3559 +23
==========================================
+ Hits 12051 12099 +48
- Misses 3336 3339 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - although have proposed changing the email content Logs...
to Logs:
as more of a header (and more consistent with the other section headers)
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
closes #4934
Description
Screenshots
Related Issue(s)
owner: #4934
parent: #4653
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label