-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move storage/auth/auditLogger/theme into launcher #100
Conversation
ebb389e
to
d3dde21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the icons be included twice? Once in theme/common
and again in resouces
Possibly not. They are in both places in the original repo, but I can't immediately see any use of them from the common folder. May need @Steve-Mcl to confirm, but I think we can remove the images from |
I have a vague memory of changing things around to use the resources but may not have "clean up" afterwards. The idea was (at the time) that the theme can have own icon or fall back to common but I am unsure where it got to in the end. (sorry) |
OK, I'm going to test this in a container this afternoon, assuming no other issues I'll test with/without the extra images and then merge as appropriate |
OK, so I removed the Auth, Storage and Audit logging appear to be working, but the theme has not been loaded. |
Team libraries are also not working |
I think I've fixed it |
Fix running in container
Okay - so I think the only remaining task is to remove the duplicate icons. I've test that locally and if it looks good, will push then get this merged. |
Part of #99
Description
This moves the following repos into this one:
@flowforge/nr-audit-logger
@flowforge/nr-auth
@flowforge/nr-storage
@flowforge/nr-theme
I have test this locally, but experience tells me the paths around module loading at subtly different in docker/k8s land. Getting this raised now to get some eyes on it, but will want to finalise some docker-based testing before we merge.
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label