Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CanRender check for ContentCase, add opinionated ".ListItem"-rendering #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielkestler
Copy link
Contributor

No description provided.

@dimaip
Copy link
Contributor

dimaip commented Dec 19, 2019

Hi @danielkestler, sorry I entirely missed this PR. What's the purpose of this new naming, I don't really get it?

@danielkestler
Copy link
Contributor Author

Ouh, this is old ... well, at the time, I thought ListItem was a better naming for this. But maybe we should rethink this altogether. Feel free to throw my PR away.

@dimaip
Copy link
Contributor

dimaip commented Dec 19, 2019

Yeah I'm overflown by notifications, sometimes it's just safer to ping me directly, especially if I'm not replying for a while... sorry about that!
As for the naming, I know my old name was quite bad, but this package is not really actively developed anymore and the whole concept of having it is rather obsolete, so I don't know if it makes much sense to cause more confusion by this API change... However if somebody is still using this package and prefers the new name I guess we could also merge it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants