Make default pagination Twitter Bootstrap compatible #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaip
reviewed
Dec 19, 2019
| @@ -31,22 +33,25 @@ prototype(Flowpack.Listable:Pagination) < prototype(Neos.Fusion:Component) { | |||
| itemRenderer = Neos.Fusion:Case { | |||
| separator { | |||
| condition = ${i == '...'} | |||
| renderer = ${'<li class="' + props.itemClass + '">' + i + '</li>'} | |||
| renderer = ${'<li class="' + props.itemClass + '"><a class="' + props.linkClass + '">' + i + '</a></li>'} | |||
There was a problem hiding this comment.
Sorry, missed this one as well.
Is it valid to have tag with no href?
There was a problem hiding this comment.
It is valid without href, yes (since HTML5). But as the world is moving from Bootstrap to Tailwind, we might have to rethink how we render the list items (looking into the direction of Fusion-components).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning, opinionated ;-) But default "Flowpack.Listable:List" also is. Could also be put into a separate "Flowpack.Listable:BootstrapPagination" prototype.