-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CUDA extension #2268
add CUDA extension #2268
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
- Coverage 80.87% 79.02% -1.86%
==========================================
Files 29 31 +2
Lines 1710 1721 +11
==========================================
- Hits 1383 1360 -23
- Misses 327 361 +34
☔ View full report in Codecov by Sentry. |
I'm pretty ambivalent on whether 1) or 2) would be better, but 2) might let us keep compat with older Julia versions if we made it load NNlibCUDA and/or the Flux CUDA code on <1.9. |
let's discuss this in #2265 |
fd7fae4
to
18adec4
Compare
@ToucheSir your suggestion works! |
This should be ready to go. After merging this I will wait a couple of days, do some local testing, then tag the v0.14 release. Cc @ToucheSir @mcabbott @darsnack |
try | ||
Base.require(Flux, :cuDNN) | ||
catch | ||
@warn """Package cuDNN not found in current path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing this warning on the GPU CI despite all the tests passing. Do you know what's going on with that?
Edit: if I print out the error from this, it's still the same not found in dependencies one :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, tried some ideas locally and this appears to work:
try
Base.require(Main, :cuDNN)
Not sure how general this is, but I haven't encountered any issues yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works!
e2693d4
to
f9e6c68
Compare
@ToucheSir everything seems fine now. Should we pull the trigger? |
No complaints from me |
Awesome! |
Building on FluxML/NNlib.jl#492, this removes CUDA as a dependency and implements option (1) in #2265, meaning that the CUDA functionality is now unlocked with the explicit double import
using CUDA, cuDNN
in users' code.Other notes:
FluxCUDA
package.