Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc of PairwiseFusion #2281

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix doc of PairwiseFusion #2281

merged 1 commit into from
Jun 29, 2023

Conversation

ctarn
Copy link
Contributor

@ctarn ctarn commented Jun 29, 2023

according to the implementation:

Flux.jl/src/layers/basic.jl

Line 637 in 24b1eb2

$(y_symbols[N + 1]) = connection($(y_symbols[i]), $(getinput(i + 1)))
, the connection of PairwiseFusion is called as connection(y1, x2) instead of connection(x2, y1).

@darsnack darsnack merged commit 34a5f98 into FluxML:master Jun 29, 2023
6 of 7 checks passed
@darsnack
Copy link
Member

Thanks!

@ctarn ctarn deleted the ctarn/doc branch June 29, 2023 11:49
@ctarn ctarn restored the ctarn/doc branch June 20, 2024 12:57
@ctarn ctarn deleted the ctarn/doc branch June 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsnack darsnack darsnack approved these changes

@vmpyr vmpyr vmpyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctarn @darsnack @vmpyr