Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Optimisers.jl v0.3 #2318

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Allow Optimisers.jl v0.3 #2318

merged 2 commits into from
Aug 25, 2023

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Aug 25, 2023

Fix #2310 fix #1982

@CarloLucibello CarloLucibello changed the title Allo Optimisers.jl v0.3 Allow Optimisers.jl v0.3 Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -37.27% ⚠️

Comparison is base (f183004) 76.83% compared to head (b7b6d7a) 39.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2318       +/-   ##
===========================================
- Coverage   76.83%   39.57%   -37.27%     
===========================================
  Files          31       21       -10     
  Lines        1809     1559      -250     
===========================================
- Hits         1390      617      -773     
- Misses        419      942      +523     

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello
Copy link
Member Author

need approval

@mcabbott
Copy link
Member

mcabbott commented Aug 25, 2023

Maybe this should link to FluxML/Optimisers.jl#151 which is what changed in Optimisers.jl

Also closes #1982 I think?

@CarloLucibello CarloLucibello merged commit 2c534d5 into master Aug 25, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

train! using Metal and stateful optimizers fails No error from negative learning rates
3 participants