-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Adapt to 4, (keep existing compat) #2362
CompatHelper: bump compat for Adapt to 4, (keep existing compat) #2362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA failure on latest stable version looks real. Does anyone have an idea of what's going on there?
I must be missing something, because the resolver complains about Adapt incompatibilities with NNlib but NNlib does allow Adapt v3. |
This should be mergeable now.
|
@christiangnrd you need to bump metal compat |
I don’t have the necessary permissions to do that. I would suggest you repurpose your PR to just update Metal compat and once merged these tests should pass. |
Close? |
This pull request changes the compat entry for the
Adapt
package from3.0
to3.0, 4
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.