Allow cpu(::DataLoader)
#2388
Merged
Allow cpu(::DataLoader)
#2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
===========================================
+ Coverage 42.55% 74.16% +31.61%
===========================================
Files 31 31
Lines 1786 1831 +45
===========================================
+ Hits 760 1358 +598
+ Misses 1026 473 -553 ☔ View full report in Codecov by Sentry. |
ToucheSir
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow
DataLoader(X) |> gpuas an idiom for moving each batch to the GPU. This allows for|> cputo work too, for symmetry, and in case you want to passdevice = cputo something which does this.PR Checklist