Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lazy strings #2402

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

lassepe
Copy link
Contributor

@lassepe lassepe commented Mar 18, 2024

In the spirit of #2400, this makes more aggressive use of LazyString.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.94%. Comparing base (a8737d7) to head (fd058ff).

Files Patch % Lines
src/functor.jl 0.00% 2 Missing ⚠️
src/layers/basic.jl 66.66% 1 Missing ⚠️
src/layers/macro.jl 50.00% 1 Missing ⚠️
src/layers/normalise.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2402       +/-   ##
===========================================
+ Coverage   43.04%   73.94%   +30.89%     
===========================================
  Files          32       32               
  Lines        1856     1911       +55     
===========================================
+ Hits          799     1413      +614     
+ Misses       1057      498      -559     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mcabbott mcabbott merged commit eb6492c into FluxML:master Mar 19, 2024
8 of 10 checks passed
@lassepe lassepe deleted the feature/more_lazy_strings branch March 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants