Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link in docs #2403

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix dead link in docs #2403

merged 1 commit into from
Mar 20, 2024

Conversation

BioTurboNick
Copy link
Contributor

Pointed to a README file in dev that doesn't exist.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (eb6492c) to head (abc5fc7).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2403       +/-   ##
===========================================
+ Coverage   43.04%   73.94%   +30.89%     
===========================================
  Files          32       32               
  Lines        1856     1911       +55     
===========================================
+ Hits          799     1413      +614     
+ Misses       1057      498      -559     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sadly this needs updating, opt.eta = next!(schedule) will only work for old-style implicit optimisers... needs to become something like Flux.adjust!(opt_state, eta = next!(schedule)) for new-style ones.

@mcabbott mcabbott merged commit d811e8b into FluxML:master Mar 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants