Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enzyme: bump version and mark models as working [test] #2439

Merged
merged 5 commits into from
May 11, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented May 7, 2024

The underlying issue from GRU was fixed on Enzyme main recently (EnzymeAD/Enzyme.jl#1261).

Seeing if they now pass CI here (conv untested, but let's see what happens).

Bumping Enzyme to later version

@wsmoses
Copy link
Contributor Author

wsmoses commented May 7, 2024

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing test failures which look Enzyme related, are those expected?

@wsmoses wsmoses closed this May 11, 2024
@wsmoses wsmoses reopened this May 11, 2024
@wsmoses
Copy link
Contributor Author

wsmoses commented May 11, 2024

@ToucheSir mind giving it a re-review. I now expect the only non-supported test is convtranspose, which should be fixed by FluxML/NNlib.jl#582.

Nevertheless enabling that test can be in a subsequent PR.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (c442f0c) to head (504ac85).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2439       +/-   ##
===========================================
+ Coverage   46.37%   74.10%   +27.72%     
===========================================
  Files          32       32               
  Lines        1876     1923       +47     
===========================================
+ Hits          870     1425      +555     
+ Misses       1006      498      -508     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello CarloLucibello merged commit 11f3fca into FluxML:master May 11, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants