Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved type stability with explicit params #1248

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Improved type stability with explicit params #1248

merged 3 commits into from
Aug 1, 2022
+109 −25

Commits on Jul 30, 2022

  1. Improved type stability with explicit params 

    We can disable accumulating (implicit) parameters to the gradient cache
in explicit mode. This can dramatically improve type stability because
`accum_param` will return a `Union{Nothing, [grad type]}` otherwise.
    @ToucheSir
    ToucheSir committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    be5b47f View commit details
    Browse the repository at this point in the history

  2. basic comment for Context{I}

    @ToucheSir
    ToucheSir committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    e9a6075 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Add accum_param tests 

    Co-authored-by: Michael Abbott <[email protected]>
    @ToucheSir @mcabbott
    ToucheSir and mcabbott committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    3433cdd View commit details
    Browse the repository at this point in the history