Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GetQRCodeUseCase and qrcode repository [#76] #81

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

DokySp
Copy link
Member

@DokySp DokySp commented Oct 10, 2024

- external camera 기능의 모듈 내 위치 변경
- QR코드 생성 및 Bitmap 반환 UseCase 추가
@DokySp DokySp added New Implementation New feature feature/external feature-external labels Oct 10, 2024
@DokySp DokySp requested review from fetiu and ing03201 October 10, 2024 15:51
@DokySp DokySp self-assigned this Oct 10, 2024
Copy link
Member

@fetiu fetiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 훑어보았고, 안드로이드 코드의 세부적인 내용까지는 이해하고 피드백 드리지는 못하지만, 어떤 방식으로 구조화되어있는지 이해했습니다. Approve 바로 하겠습니다! 필요하신 경우 @ing03201 리뷰까지 받고 머지해주세요!

qrImage = BitmapFactory.decodeFile(qrImageFile.absolutePath)
}
return qrImage
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

설계적으로 보았을 때, readCachedQRCodeImage이 범용적이여야하는 FileUtil안에 있는게 바람직하지 않은 의존성 같다고 느껴지네요.

하지만 말씀하셨듯 Phase2의 시급성을 고려해서 이대로 진행해도 좋을 것 같습니다. 나중에 이 부분이 해결될 것이라는 것을 TODO주석 등으로 남기면 좋을 것 같다고 생각합니다.

@ing03201 ing03201 merged commit 2e92035 into FoKE-Developers:main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/external feature-external New Implementation New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants