Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _originalImageWidth & _Height #711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coeur2Boeuf
Copy link

On rotate image, the _originalImageWidth & _originalImageHeight are not updated... So, the result was on the old value.
This example, fix this issue.

On rotate image, the _originalImageWidth & _originalImageHeight are not updated... So, the result was on the old value.
This example, fix this issue.
@webmasterMeyers
Copy link

This fix works for me on v2.6.4, please merge!

@michael-letcher
Copy link
Contributor

Fixes #699 & #668

@tristanbenier
Copy link

This works for me as well on v2.6.4, please merge it !

@Uleertel
Copy link

Uleertel commented Jun 9, 2020

I tried to use this fix by using the fork from Coeur2Boeuf and it didn't work.
The explanation is that on the master branch of croppie there is already a fix for it just a few lines after this fix!
The fork by Coeur2Boeuf is based on the master so we have a double fix that cancel each other....
So either use the fix of Coeur2Boeuf or use the master branch but do not use both!
So what we need really is a 2.7 from master. Someone knows if master is stable as it is?

@andrewflon
Copy link

This works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants