Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create loan, deposit, borrowing and linking address examples #209

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

moshenskyDV
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 6df0b2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@folks-finance/xchain-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@folks-finance/xchain-sdk@209

commit: 6df0b2e

@moshenskyDV moshenskyDV marked this pull request as ready for review January 6, 2025 10:40
Copy link
Member

@gidonkatten gidonkatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall examples look good, I left some comments for things to change

examples/borrow-stable-rate.ts Outdated Show resolved Hide resolved
examples/borrow-stable-rate.ts Outdated Show resolved Hide resolved
examples/deposit-collateralise.ts Outdated Show resolved Hide resolved
examples/borrow-stable-rate.ts Outdated Show resolved Hide resolved
examples/borrow-variable-rate.ts Outdated Show resolved Hide resolved
examples/liquidate.ts Outdated Show resolved Hide resolved
examples/create-loan.ts Outdated Show resolved Hide resolved
examples/deposit-collateralise.ts Outdated Show resolved Hide resolved
examples/link-address.ts Outdated Show resolved Hide resolved
examples/liquidate.ts Show resolved Hide resolved
Copy link
Member

@gidonkatten gidonkatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moshenskyDV moshenskyDV merged commit 4d125ba into main Jan 7, 2025
5 checks passed
@moshenskyDV moshenskyDV deleted the docs/create-loan-and-deposit-examples branch January 7, 2025 11:49
gidonkatten pushed a commit that referenced this pull request Jan 7, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @folks-finance/[email protected]

### Patch Changes

- [#209](#209)
[`4d125ba`](4d125ba)
Thanks [@moshenskyDV](https://github.com/moshenskyDV)! - Added more
examples

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants