Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowance state override in deposit #44

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

palace22
Copy link
Collaborator

@palace22 palace22 commented Jun 7, 2024

No description provided.

@palace22 palace22 requested a review from gidonkatten June 7, 2024 16:56

const folksTokenContractSlot = contractSlot.folksToken[folksTokenId];
if (!folksTokenContractSlot) {
throw new Error(`Folks Token not found for folksTokenId: ${folksTokenId}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contract slot not found for folksTokenId: ${folksTokenId}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return folksTokenContractSlot;
}

export function getAllowanceStateOverride(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we ever need to override multiple allowances? If so maybe we should change this function to take in array as parameter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palace22 palace22 requested a review from gidonkatten June 7, 2024 17:37
@palace22 palace22 merged commit e7e8937 into main Jun 7, 2024
2 checks passed
@palace22 palace22 deleted the feat/allowance-state-override branch June 7, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants