Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript typings #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axelo
Copy link

@axelo axelo commented Oct 19, 2022

While using the current typings I detected some inconsistency with the underlying JavaScript code. This PR tries to fix that.

Some notable changes are defaulting to unknown instead of any.

The updated typings has been compiled and ran against our internal TypeScript backend successfully.

@zlintz
Copy link
Member

zlintz commented Feb 19, 2023

I am inclined to accept this change given I don't see anyone else interested in typing things otherwise. Anyone opposed? will leave this a bit longer but this seems reasonable. That said, I may change things in the future but I will version the repo accordingly.

@zlintz
Copy link
Member

zlintz commented Mar 9, 2023

Any chance you would be willing to update the commit message to align with https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style and we will get this merged? Also please rebase in the process

@zlintz
Copy link
Member

zlintz commented Nov 21, 2023

Following up here, is this still something you want? Or others?

@zlintz
Copy link
Member

zlintz commented Nov 21, 2023

If you still want this please follow https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style or just rebase and use npm run commit which takes care of it for you. Otherwise I may still just take these change for myself, I would rather you get the credit for the efforts though. These look good overall

@axelo
Copy link
Author

axelo commented Nov 22, 2023

If you still want this please follow https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style or just rebase and use npm run commit which takes care of it for you. Otherwise I may still just take these change for myself, I would rather you get the credit for the efforts though. These look good overall

Really sorry for late answer! Unfortunately I have too little time to fix this, sorry again :/ No worries about credits, please use the parts you deem valid and close this PR.

Thanks for doing this in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants