Update to Bevy 0.12. #43
Conversation
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
| @@ -724,7 +723,8 @@ pub fn render_app_builder(app: &mut App) { | |||
| ) | |||
| .add_systems( | |||
| Render, | |||
| (queue_infinite_grids, queue_grid_view_bind_groups).in_set(RenderSet::Queue), | |||
| (queue_infinite_grids, queue_grid_view_bind_groups) | |||
| .in_set(RenderSet::PrepareBindGroups), | |||
There was a problem hiding this comment.
I'm not sure I understand why this is necessary. I understand that the sets were reordered but the Queue set should still be used to queue things. I haven't touched this code that much though so it's possible it's doing something incompatible with that.
There was a problem hiding this comment.
The problem was that you put bind group creation and queuing into the same system, while Bevy 0.12 wants them to be in separate systems. I've split up the logic appropriately.
There was a problem hiding this comment.
Ah, thank you for the investigation, I didn't implement the crate originally so I wasn't aware of that.
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Everything seems to work in both the simple example and in my own app.
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
|
OK, I discovered that the shadow was broken, so this PR fixes that too. That required some fairly large surgery. I've also updated the PR to use the This should be ready to go now. |
aevyrie
merged commit 5897bb6
into
ForesightMiningSoftwareCorporation:main
|
Thanks @pcwalton! |
Everything seems to work in both the simple example and in my own app.
The one thing I wasn't sure about was whether to rename the
queue_methods toprepare_now that they've been moved to thePrepareBindGroupsrender set. They had to be moved there because in Bevy 0.12Queueexecutes beforePrepare, whereas this crate expected them to execute in the other order.