Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug causing grid colors to invert #65

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fixes bug causing grid colors to invert #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adc33f4
Cant replicate it in the example so pushing to replicate on priv repo
TheEppicJR Jul 8, 2024
208e51d
should have been a min
TheEppicJR Jul 8, 2024
93402e2
maybe this fixes it?
TheEppicJR Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/render/grid.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ fn fragment(in: VertexOutput) -> FragmentOutput {
let grid2 = abs(fract((coord * 0.1) - 0.5) - 0.5) / derivative2;
let mg_line = min(grid2.x, grid2.y);

let grid_alpha = 1.0 - min(lne, 1.0);
let grid_alpha = max(1.0 - min(lne, 1.0), 0.0);
let base_grid_color = mix(grid_settings.major_line_col, grid_settings.minor_line_col, step(1., mg_line));
var grid_color = vec4(base_grid_color.rgb, base_grid_color.a * grid_alpha);

Expand All @@ -118,7 +118,7 @@ fn fragment(in: VertexOutput) -> FragmentOutput {
grid_color = mix(grid_color, vec4(grid_settings.z_axis_col, grid_color.a), f32(z_axis_cond));
grid_color = mix(grid_color, vec4(grid_settings.x_axis_col, grid_color.a), f32(x_axis_cond));

let dist_fadeout = min(1., 1. - grid_settings.dist_fadeout_const * real_depth);
let dist_fadeout = min(1., 1. - min(grid_settings.dist_fadeout_const * real_depth, 1.));
let dot_fadeout = abs(dot(grid_position.normal, normalize(view.world_position - frag_pos_3d)));
let alpha_fadeout = mix(dist_fadeout, 1., dot_fadeout) * min(grid_settings.dot_fadeout_const * dot_fadeout, 1.);

Expand Down
Loading