fix(permissions): fetch permissions return an exception when the server doesn't return an 200 response #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthv
changed the title
Thenkei
reviewed
Oct 23, 2023
| if response.is_a?(Net::HTTPOK) | ||
| JSON.parse(response.body) | ||
| else | ||
| raise ForestLiana::Errors::HTTP403Error.new("Permission could not be retrieved") |
Thenkei
reviewed
Oct 23, 2023
| @@ -6,7 +6,7 @@ module Ability | |||
| module Permission | |||
| include Fetch | |||
|
|
|||
| TTL = (ENV['FOREST_PERMISSIONS_EXPIRATION_IN_SECONDS'] || 1).to_i.second | |||
|
Code Climate has analyzed commit af78c98 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (55% is the threshold). This pull request will bring the total coverage in the repository to 48.7%. View more on Code Climate. |
nicolasalexandre9
approved these changes
Oct 23, 2023
forest-bot
added a commit
that referenced
this pull request
Oct 23, 2023
## [8.0.15](v8.0.14...v8.0.15) (2023-10-23) ### Bug Fixes * **permissions:** fetch permissions return an exception when the server doesn't return an 200 response ([#635](#635)) ([9a7590b](9a7590b))
|
🎉 This PR is included in version 8.0.15 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Watanabe1011
added a commit
to Watanabe1011/Forest-Rails
that referenced
this pull request
Jun 3, 2024
## [8.0.15](ForestAdmin/forest-rails@v8.0.14...v8.0.15) (2023-10-23) ### Bug Fixes * **permissions:** fetch permissions return an exception when the server doesn't return an 200 response ([#635](ForestAdmin/forest-rails#635)) ([9a7590b](ForestAdmin/forest-rails@9a7590b))
montedev0516
added a commit
to montedev0516/Artizyou-Platform
that referenced
this pull request
Nov 7, 2024
## [8.0.15](ForestAdmin/forest-rails@v8.0.14...v8.0.15) (2023-10-23) ### Bug Fixes * **permissions:** fetch permissions return an exception when the server doesn't return an 200 response ([#635](ForestAdmin/forest-rails#635)) ([9a7590b](ForestAdmin/forest-rails@9a7590b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security