Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] rma_delivery: add default_carrier_in_id #302

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

mariadforgeflow
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #302 (dffcf67) into 14.0 (23d00a1) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #302      +/-   ##
==========================================
- Coverage   80.12%   80.07%   -0.05%     
==========================================
  Files         138      138              
  Lines        4497     4501       +4     
  Branches      846      848       +2     
==========================================
+ Hits         3603     3604       +1     
- Misses        691      693       +2     
- Partials      203      204       +1     
Impacted Files Coverage Δ
rma_delivery/tests/test_rma_delivery.py 100.00% <ø> (ø)
rma_delivery/wizard/rma_make_picking.py 75.00% <25.00%> (-25.00%) ⬇️
rma_delivery/models/rma_operation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d00a1...dffcf67. Read the comment docs.

@LoisRForgeFlow
Copy link
Contributor

@ChrisOForgeFlow can you have a look at this one?

Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rma_delivery/models/rma_operation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariadforgeflow mariadforgeflow changed the title [14.0][IMP] rma_delivery: add default_carrier_id_in [14.0][IMP] rma_delivery: add default_carrier_in_id Dec 27, 2022
@AaronHForgeFlow
Copy link
Contributor

@LoisRForgeFlow ok to merge?

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Oct 27, 2023

@AaronHForgeFlow eventually, this wasn't implemented in the project that triggered the need, so up to you to include it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants