-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] rma_delivery: add default_carrier_in_id #302
base: 14.0
Are you sure you want to change the base?
Conversation
6c4d990
to
a1609a1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #302 +/- ##
==========================================
- Coverage 80.12% 80.07% -0.05%
==========================================
Files 138 138
Lines 4497 4501 +4
Branches 846 848 +2
==========================================
+ Hits 3603 3604 +1
- Misses 691 693 +2
- Partials 203 204 +1
Continue to review full report at Codecov.
|
@ChrisOForgeFlow can you have a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a1609a1
to
8ede7d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8ede7d2
to
9ec116c
Compare
9ec116c
to
dffcf67
Compare
@LoisRForgeFlow ok to merge? |
@AaronHForgeFlow eventually, this wasn't implemented in the project that triggered the need, so up to you to include it or not. |
@LoisRForgeFlow