[16.0][ADD] rma_repair_put_away: glue module between rma_repair & rma_put_away #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
changed the title
AaronHForgeFlow
force-pushed
the
16.0-rma_repair_putaway
branch
from
b23c31b
to
c5e3619
Compare
JordiMForgeFlow
approved these changes
Aug 2, 2024
MiquelRForgeFlow
approved these changes
Aug 2, 2024
|
|
|
@ChrisOForgeFlow do you think this is fine? |
Yes, thank you |
ChrisOForgeFlow
approved these changes
Aug 20, 2024
|
@ChrisOForgeFlow thank you. I will add a test and merge it. |
When not using rma_put_away you can define push rules anyway to move the products to the repair location, and those transfers count as rma repair transfers if you install and use rma_put_away then the rma repair transfers are the ones from the putaway moves Before this commit there is a dependency issue because the rma_repair code is using a field declared in the rma_put_away, this commit fixes that issue [IMP] rma_repair_put_away: added tests
AaronHForgeFlow
force-pushed
the
16.0-rma_repair_putaway
branch
from
c5e3619
to
315ca02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using rma_put_away you can define push rules anyway to move the products to the repair location, and those transfers count as rma repair transfers
If you install and use rma_put_away then the rma repair transfers are the ones from the putaway moves
Before this commit there is a dependency issue because the rma_repair code is using a field declared in the rma_put_away, this commit fixes that issue.