Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests, move hard coded URLs to one place, change test url #238

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

vahancouver
Copy link
Contributor

JIRA Ticket

SDKS-2637

Description

[iOS] Review/Fix unstable/flaky tests in iOS

Improve unit tests
Move hard coded URLs to one place
Change test url

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

Updated hostname and public key hash for certificate pinning tests
@spetrov spetrov merged commit edaae6b into develop Dec 6, 2023
6 of 7 checks passed
@spetrov spetrov deleted the SDKS-2637-improve-tests branch December 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants