Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccountMigrationManager with OTP accounts import and export methods #240

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

vahancouver
Copy link
Contributor

JIRA Ticket

SDKS-2730

Description

[FRA][iOS] Implement Export and Import functions for OTP accounts

public var errorUserInfo: [String : Any] {
switch self {
case .invalidScheme:
return [NSLocalizedDescriptionKey: "Invalid schem in url given for Account Migration"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Invalid scheme

}


/// Decodes given OTPAauth Migration `URL` to otpauth `URL`s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Decodes given OTPAuth

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏻

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@spetrov spetrov merged commit d7ddc3f into develop Oct 25, 2023
6 of 7 checks passed
@spetrov spetrov deleted the SDKS-2730-otp-account-export-import branch October 25, 2023 21:52
@spetrov spetrov restored the SDKS-2730-otp-account-export-import branch November 9, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants