Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdks 3086 privacy manifests #274

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Sdks 3086 privacy manifests #274

merged 10 commits into from
Apr 23, 2024

Conversation

vahancouver
Copy link
Contributor

SDKS-3086

[iOS] Add Privacy Manifests to SDK

  1. Update Google SDK to 7.1.0
  2. Remove storage(diskSpace) from HardwareCollector
  3. Add Privacy Manifests to all modules
  4. Update Signals SDK to 5.2.3
  5. Update FRFacebookSignIn Privacy Manifest to reflect Facebook iOS SDK privacy manifest
  6. Change SPM dependency versions from exactVersion to upToNextMinorVersion

rodrigoareis
rodrigoareis reviewed Apr 23, 2024
View reviewed changes
FRAuth/FRAuthTests/FRAuthSwiftTests/FRAuth/Device/FRDeviceCollectorTests.swift Outdated
@@ -81,7 +81,7 @@ class FRDeviceCollectorTests: FRAuthBaseTest {
XCTAssertNotNil((hardware["cpu"] as? Int))
// XCTAssertNotNil((hardware["activeCPU"] as? Int))
XCTAssertNotNil((hardware["memory"] as? Int))
XCTAssertNotNil((hardware["storage"] as? Int))
// XCTAssertNotNil((hardware["storage"] as? Int))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, would nice to have a short comment why it has been commented out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

rodrigoareis
rodrigoareis requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good. Minor comments to address

spetrov
spetrov approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

rodrigoareis
rodrigoareis approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@spetrov spetrov merged commit fdb8b79 into develop Apr 23, 2024
8 of 9 checks passed
@spetrov spetrov deleted the SDKS-3086-privacy-manifests branch April 23, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetrov spetrov spetrov approved these changes

@rodrigoareis rodrigoareis rodrigoareis approved these changes

@jeyanthanperiyasamy jeyanthanperiyasamy Awaiting requested review from jeyanthanperiyasamy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vahancouver @spetrov @rodrigoareis