Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKS-1753 WebAuthn Device Management #281

Merged
merged 2 commits into from
May 27, 2024
Merged

SDKS-1753 WebAuthn Device Management #281

merged 2 commits into from
May 27, 2024

Conversation

rodrigoareis
Copy link
Contributor

JIRA Ticket

SDKS-1753 WebAuthn Device Management

Description

Briefly describe the change and any information that would help speedup the review and testing process.

Definition of Done Checklist:

  • Acceptance criteria is met.
  • All tasks listed in the user story have been completed.
  • Coded to standards.
  • Ensure backward compatibility.
  • API reference docs is updated.
  • Unit tests are written.
  • Integration tests are written.
  • e2e tests are written.
  • Functional spec is written/updated.
  • Example code snippets have been added.
  • Change log updated.
  • Documentation story is created and tracked.
  • Tech debts and remaining tasks are tracked in separated ticket(s).

@rodrigoareis rodrigoareis self-assigned this May 22, 2024
vahancouver
vahancouver approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@vahancouver vahancouver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

spetrov
spetrov approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@spetrov spetrov merged commit a4baee6 into develop May 27, 2024
5 of 9 checks passed
@spetrov spetrov deleted the SDKS-1753 branch May 27, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetrov spetrov spetrov approved these changes

@vahancouver vahancouver vahancouver approved these changes

Assignees

@rodrigoareis rodrigoareis

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigoareis @spetrov @vahancouver