Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdks 3429 fix tests #305

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Sdks 3429 fix tests #305

merged 3 commits into from
Sep 25, 2024

Conversation

vahancouver
Copy link
Contributor

@vahancouver vahancouver commented Sep 19, 2024 •
edited
Loading

SDKS-3429

Fix Tests Issues and add improvements

  1. Add FRCaptchaEnterprise to FRUI and to FRTestHost
  2. Add FRTestHost as and host app to FRCaptchaEnterprise, FRFacebookSignIn, FRGoogleSignIn, FRUI, PingProtect
  3. Change idp tests due to FB and google handlers availability

spetrov
spetrov approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

rodrigoareis
rodrigoareis approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@spetrov spetrov merged commit 68b7749 into develop Sep 25, 2024
9 checks passed
@spetrov spetrov deleted the SDKS-3429-fix-tests branch September 25, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetrov spetrov spetrov approved these changes

@rodrigoareis rodrigoareis rodrigoareis approved these changes

@jeyanthanperiyasamy jeyanthanperiyasamy Awaiting requested review from jeyanthanperiyasamy

@george-bafaloukas-forgerock george-bafaloukas-forgerock Awaiting requested review from george-bafaloukas-forgerock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vahancouver @spetrov @rodrigoareis