Рефакторинг #141
Merged
Рефакторинг #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoWaster
reviewed
May 5, 2024
|
Я правильно понимаю, что у нас здесь правки, которые не должны ничего сломать и их можно будет влить до экзамена? |
Угу. По крайней мере у меня всё локально работало исправно |
WoWaster
reviewed
May 6, 2024
gsvgit
reviewed
May 7, 2024
gsvgit
reviewed
May 7, 2024
|
И раз уж пошло такое дело, то надо issues пересмотреть. |
gsvgit
reviewed
May 10, 2024
| @pytest.fixture(scope="function", params=range(8)) | ||
| def graph(request) -> MultiDiGraph: | ||
| fun = random.choice(funcs) | ||
| # task 6 takes a long time if there are ranges [1, 100] |
There was a problem hiding this comment.
Интересно, почему. По идее, 100 вершин --- ерунда.
Put constants into one file, make some reusable helper functions and template of rpq and cfpq test
WoWaster
approved these changes
May 10, 2024
There was a problem hiding this comment.
Совсем мелкая претензия: это уже просто template_tests.py или что-то в этом духе :)
gsvgit
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.