-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all input element styles #181
Conversation
🦋 Changeset detectedLatest commit: 4a14601 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size?: 'small' | 'standard' | 'large'; | ||
border?: 'standard' | 'ghost'; | ||
border?: 'standard' | 'none'; | ||
Icon?: React.FC<any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to pass any
here or could we do something like Record<string, unknown>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Lucide Icon library doesn't have a generic type that works, so for now its just <any>
/shrug
size === 'small' && 'p-1.5 text-xs', | ||
size === 'small' && !!children && 'px-2', | ||
|
||
// externals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the comments here to help make it clear what styles are part of what variant!
Updates all input elements with final design styles and colors.
Before
After