Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor schema into nested fields #49

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Refactor schema into nested fields #49

merged 2 commits into from
Sep 19, 2023

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Sep 18, 2023

Refactor schema into nested fields

Copy link
Member

@kgpax kgpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made a couple of updates based on || vs ?? and omitted some unneeded casting/coalescing.

Great stuff

@kgpax kgpax merged commit 9c6780b into main Sep 19, 2023
3 checks passed
@kgpax kgpax deleted the refactor/schema branch September 19, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants