chore pnpm v8 #207
Merged
chore pnpm v8 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nlkluth
requested review from
scottrippey,
carloskelly13 and
colinrobertbrooks
carloskelly13
approved these changes
Oct 24, 2023
scottrippey
requested changes
Oct 24, 2023
scottrippey
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade pnpm to v8
Why
Breakout update to isolate breaking changes
Info
Vercel automatically supports v8 with a 6.0 lockfile https://vercel.com/changelog/automatic-pnpm-v8-support
It seems like we are in a bit of a mixed state between lockfile 6.0 and pnpm@8. Running
pnpm iwith the latest lockfile won't make any changes, however if you delete the lockfile and run it will generate the new file (as in this PR) withautoInstallPeers: truewhich is the major change. This is also true if you make any workspaces changes, which is what I am running into.This is breaking CI which has frozen lockfile settings. My PR was failing due to this change. Downgrading my pnpm was not the answer, and this change to
pnpm-lock.ymlseems almost unavoidable with the latest pnpm version once you make any change.Help
We'll need to get around the frozen lockfile as a one-time deal 🤔