Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/migration #209

Merged
merged 48 commits into from
Nov 6, 2023
Merged

Chore/migration #209

merged 48 commits into from
Nov 6, 2023

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Nov 2, 2023

What

Moves cart to shared-ui

Why

Part of component library migration. Future projects can easily add UI like cart

Info/future work

  • types could probably be generalized more
  • sub components could be broken up for greater render flexibility

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-sanity-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 4:50pm

Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one question!

@nlkluth nlkluth merged commit 0adba6a into main Nov 6, 2023
7 of 8 checks passed
@nlkluth nlkluth deleted the chore/migration branch November 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants