Feature/clientside refactor #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nlkluth
commented
Dec 13, 2023
| @@ -0,0 +1,21 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
A few of these added to follow this pattern https://nextjs.org/docs/app/building-your-application/rendering/composition-patterns#supported-pattern-passing-server-components-to-client-components-as-props
| // if a single element is selected, type would be a string instead of an array. | ||
| const totalFilters = typeof selectedFilters === "string" ? (elements > 0 ? 1 : 0) : elements; | ||
| const total = filters.reduce((acc: number, { value }: FilterGroup) => { | ||
| const selectedFilters = query?.getAll(value); |
There was a problem hiding this comment.
Sneaking in a bug fix. I broke multiple filter select before 🤭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves 'use client' boundary to further down the tree
Why
Lowers bundle size by having more server components