Upgrade node versions, remove side effect, use named exports

FormidableLabs · Feb 28, 2024 · bcf2cf1 · bcf2cf1
1 parent 638b378
commit bcf2cf1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/storybook-tests.yml b/.github/workflows/storybook-tests.yml
@@ -5,13 +5,13 @@ jobs:
     timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: pnpm/action-setup@v2.2.2
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3.0.0
         with:
           version: 7
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: 18.x
       - name: Install dependencies
         run: pnpm install
       - name: Install Playwright

diff --git a/packages/nuka/package.json b/packages/nuka/package.json
@@ -93,7 +93,7 @@
     "url": "https://github.com/FormidableLabs/nuka-carousel/issues"
   },
   "homepage": "https://github.com/FormidableLabs/nuka-carousel",
-  "sideEffects": true,
+  "sideEffects": false,
   "publishConfig": {
     "provenance": true
   }

diff --git a/packages/nuka/src/index.tsx b/packages/nuka/src/index.tsx
@@ -1 +1 @@
-export { Carousel as default, SlideHandle } from './Carousel/Carousel';
+export { Carousel, SlideHandle } from './Carousel/Carousel';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export { Carousel as default, SlideHandle } from './Carousel/Carousel';
		export { Carousel, SlideHandle } from './Carousel/Carousel';