Skip to content

Commit

Permalink
use node 18 and clear pipeline warnings (#134)
Browse files Browse the repository at this point in the history
<!--

For more information on any of the below, please see our Contributing
guidelines:

https://github.com/FormidableLabs/react-fast-compare/blob/master/CONTRIBUTING.md#before-submitting-a-pr

-->

## Description

As part of an internal Formidable Open Source audit, we're going through
and updating some GH actions to no longer use unsupported versions of
node. Also, removing them from our testing pipelines.

I also noticed we weren't utilizing a cache for yarn, so I added that
into `setup-node` action to speed things up slightly.


## Checklist:

- [x] All tests are passing
- [x] Type definitions, if updated, pass both `test-ts-defs` and
`test-ts-usage`
- [x] Benchmark performance has not significantly decreased
- [x] Bundle size has not been significantly impacted
- [x] The bundle size badge has been updated to reflect the new size

---------

Co-authored-by: Sawyer Burnett <[email protected]>
  • Loading branch information
Burnett2k and Sawyer Burnett authored Mar 20, 2024
1 parent 01b5798 commit 6f7d8af
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
- ubuntu-latest
- windows-latest
node_version:
- 14
- 16
- 18
name: Node ${{ matrix.node_version }} on ${{ matrix.os }}
steps:
Expand All @@ -27,10 +25,11 @@ jobs:
run: |
git config --global core.autocrlf false
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: ${{ matrix.node_version }}
- name: Install Dependencies
run: yarn install --frozen-lockfile
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ jobs:
packages: write
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: 18

- name: Install dependencies
Expand Down

0 comments on commit 6f7d8af

Please sign in to comment.