Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve readability of method arguments be renaming headers argument to customHeaders #899

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

robwalkerco
Copy link
Member

Description

#734 highlighted that the config key in JS does not match the argument name used in the native Android methods.
This PR just renames the argument internally for improved readability.

Steps to verify

There are no functional changes in this PR.

@robwalkerco robwalkerco merged commit 129f047 into main Sep 6, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
@robwalkerco robwalkerco deleted the chore/android-readability branch September 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants