Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete recording bug #40

Closed
7 tasks done
Uj947nXmRqV2nRaWshKtHzTvckUUpD opened this issue Mar 3, 2024 · 6 comments
Closed
7 tasks done

Delete recording bug #40

Uj947nXmRqV2nRaWshKtHzTvckUUpD opened this issue Mar 3, 2024 · 6 comments
Assignees
Labels
bug Something is not working

Comments

@Uj947nXmRqV2nRaWshKtHzTvckUUpD

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 12

Affected device model

OP

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

record something
attempt to delete

Expected behavior

able to delete recording

Actual behavior

cannot delete recording. a popup appears to allow deletion, i press allow, yet nothing happens. installed from neo store

Screenshots/Screen recordings

No response

Additional information

related to #39

@Uj947nXmRqV2nRaWshKtHzTvckUUpD Uj947nXmRqV2nRaWshKtHzTvckUUpD added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Mar 3, 2024
@Aga-C
Copy link
Member

Aga-C commented Mar 3, 2024

Have you changed the path where recordings are saved?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Mar 3, 2024
@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link
Author

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Mar 3, 2024

yes, i changed it to Internal/Recordings/Voice Recordings (created the folder 'Voice Recordings' manually using fossify file manager)

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Mar 3, 2024
@Aga-C Aga-C removed question Further information is requested needs triage Issue is not yet ready for PR authors to take up labels Mar 3, 2024
@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link
Author

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Mar 3, 2024

Screenshot_2024-03-03-13-09-46-99_da8e1b33c587c7c6dfcf439d19f6f0d3

after i press allow, nothing happens. i can repeat this many times, with same result

  • also note the grey area which seems kinda odd

@Robio
Copy link

Robio commented Apr 21, 2024

Having a similar experience with 1.0.0 from Google Play Store.

Voice Recorder bombs every time I try to delete files from within the app

  • The app asks about bypassing the recycle (no), then I get a system pop-up asking for permission for the app to delete files (yes), then the file appears to be gone...then the app bombs
  • On relaunch, the file is still there, and the same steps produce the same results.

If I turn off recycle bin in Settings

  • The app no longer bombs, but does continue to ask for permission with every file I delete
  • The file appears to have been deleted (no longer listed in the app)
  • Quit and relaunch the app — deleted file is there again (was not actually deleted)

ALSO

  • Turning on/off recycle in the Settings takes 4-5 seconds

v1.0.0 from Google Play
Android 11
2020 Moto G Power
Save recordings in: SD Card/Recordings

@ljb279
Copy link

ljb279 commented Sep 4, 2024

I can confirm this and have some more info that might help. (Using Android 13, installed with APK from F-Droid)

  1. After installation, files can be deleted or moved to trash. But after confirming, there is a second popup that asks "Allow Voice Recorder to delete this audio file?"

  2. Once you change the "Save recordings in" setting to a different path, you will never be able to delete files or move them to trash again. There is no error message but the operation completes and the file is still there.

  3. Even if you change "Save recordings in" back to the original value Internal/Music/Recordings, you will still not be able to delete files or move files to trash.

  4. If you use Android Settings to clear storage and cache for the app, the app settings are all reset and file delete and move to trash work again.

  5. The second popup, which appears when trying to delete a file and asks "Allow Voice Recorder to delete this audio file?", might be related to this bug or separate. I don't think the second popup should appear. (Could it be that the app should be requesting "Music and Audio permissions"? I see that a different recorder app does request that permission.) I noticed that when file delete works, the popup contains an enlarged "Audio file" icon - headphones - in the central area. When file delete will not work, the central area of this popup is empty.

@naveensingh naveensingh self-assigned this Jan 4, 2025
@naveensingh
Copy link
Member

naveensingh commented Jan 5, 2025

So, here's how the app works right now:

Up to Android 10: Requests WRITE_EXTERNAL_STORAGE permission. All is good.
Android 11 and above: No permissions requested. App can write to MediaStore but can not read those files after a reinstall.

I am considering the following:

Up to Android 10: Request WRITE_EXTERNAL_STORAGE permission. No change.
Android 11 and 12: Request READ_EXTERNAL_STORAGE permission.
Android 13 and above: Request READ_MEDIA_AUDIO permission.

It is possible to resolve these issues without introducing new permissions but these two issues (#24, #40) are proof that the current SAF+MediaStore based approach is error prone. What the app is doing now to save/access/delete recordings is very convoluted.

naveensingh added a commit that referenced this issue Jan 7, 2025
Closes #40

As a side effect, the following issues were also addressed:

Closes #24

Closes #60

Closes #74
naveensingh added a commit that referenced this issue Jan 7, 2025
Closes #40

As a side effect, the following issues were also addressed:

Closes #24

Closes #60

Closes #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

5 participants