Consistency for poison

Fraunhofer-AISEC · Nov 8, 2024 · a0c327d · a0c327d
1 parent 897fca2
commit a0c327d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/cpg-language-llvm/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/llvm/StatementHandler.kt b/cpg-language-llvm/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/llvm/StatementHandler.kt
@@ -741,12 +741,8 @@ class StatementHandler(lang: LLVMIRLanguageFrontend) :
         condition.lhs = undefCheck
         val poisonCheck = newBinaryOperator("!=", rawNode = instr)
         poisonCheck.lhs = operand
-        poisonCheck.rhs =
-            newLiteral(
-                "POISON",
-                operand.type,
-                rawNode = instr
-            ) // This could be e.g. NAN. Not sure for complex types
+        // This could be e.g. NAN. Not sure for complex types
+        poisonCheck.rhs = newReference("poison", operand.type, rawNode = instr)
         condition.rhs = poisonCheck
 
         // Call to a dummy function "llvm.freeze" which would fill the undef or poison values

diff --git a/...guage-llvm/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/llvm/StatementHandlerTest.kt b/...guage-llvm/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/llvm/StatementHandlerTest.kt
@@ -748,8 +748,8 @@ class StatementHandlerTest {
         assertIs<BinaryOperator>(poisonCheck)
         assertEquals("!=", poisonCheck.operatorCode)
         assertRefersTo(poisonCheck.lhs, wDeclaration)
-        // poison is modeled as the string "POISON"
-        assertLiteralValue("POISON", poisonCheck.rhs)
+        // poison is modeled as a reference "poison"
+        assertLocalName("poison", poisonCheck.rhs)
 
         assertRefersTo(freezeInstruction.thenExpression, wDeclaration)